fix(tagLabel): lenient appliedAt date deserialization#27771
Open
Khairajani wants to merge 5 commits intomainfrom
Open
fix(tagLabel): lenient appliedAt date deserialization#27771Khairajani wants to merge 5 commits intomainfrom
Khairajani wants to merge 5 commits intomainfrom
Conversation
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Khairajani
added
the
safe to test
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Accept ISO-8601 datetimes with or without fractional seconds for
TagLabel.appliedAt. Python clients omit fractional when a datetime's
microsecond is zero, emitting strings like "2026-04-24T10:27:06Z" that
the strict global SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSSSS'Z'")
rejects, causing PATCH operations to fail with "Failed to convert
JsonValue to target class".
Khairajani
force-pushed
the
fix_taglabel_appliedat_lenient_parse
branch
from
22c5e27 to
5788f98
Compare
Contributor
🔴 Playwright Results — 19 failure(s), 15 flaky✅ 3941 passed · ❌ 19 failed · 🟡 15 flaky · ⏭️ 86 skipped
Genuine Failures (failed on all attempts)❌
|
…ption JsonUtils.readValue catches JsonProcessingException and rethrows as JsonParsingException, so the public-API caller observes the wrapper. Assert on the wrapper type and verify the cause chain carries the underlying Jackson mapping exception with the field path context.
Code Review ✅ Approved 1 resolved / 1 findingsUpdates tagLabel deserialization to use LenientIsoDateDeserializer, resolving the unhandled DateTimeParseException. The implementation is robust and no further issues were found. ✅ 1 resolved✅ Edge Case: LenientIsoDateDeserializer doesn't wrap DateTimeParseException
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TagLabel.appliedAtis typedjava.util.Dateand the global JacksonObjectMapperis configured withSimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSSSS'Z'")— which strictly requires 6-digit fractional seconds on parse. Python clients using Pydantic emit datetimes viadatetime.isoformat(), which omits the fractional part entirely whenmicrosecond == 0(~1/1000 odds per timestamp). The result is a payload like"2026-04-24T10:27:06Z"that the server cannot deserialize, surfacing as:This was causing intermittent automator propagation failures in CI — every PATCH carrying a round-tripped
appliedAtwithmicrosecond=0was being rejected. Same class of bug as thetag_usage.appliedAtprecision fix in the 1.11.8 / 1.12.0 MySQL migrations, just on the wire side.Fix
Register a Jackson mixin on
TagLabelthat deserializesappliedAtviaInstant.parse(), which accepts both forms:"2026-04-24T10:27:06Z"(no fractional)"2026-04-24T10:27:06.918000Z"(with fractional)Mixin is added to the global
OBJECT_MAPPERbefore any.copy(), so all five derived mappers inherit it. No generated code is touched. Serialization is unchanged (still always emits 6-digit fractional from the global format).Test plan
JsonUtilsTest#testTagLabelAppliedAtAcceptsBareSecondPrecisioncovering both formsmvn compile -pl openmetadata-specpassesmvn spotless:applyclean